Addresses issues with #hmset not string-ifying keys, and not accepting Array as only arg. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to date
This was referenced Oct 8, 2019
JeffLuckett
force-pushed
the
fixes_hash_keys
branch
from
4033b0e
to
429afe4
Compare
JeffLuckett
changed the title
JeffLuckett
changed the title
…fferent argument patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #170
HashMethods was not converting keys to strings when initially creating a Hash key, leading to inability to use
delmethod and other issues.I've also addressed the issue raise in #134. Allows
.hmsetto accept an array as its only argument. eg:mr.hmset([:fee, :fi, :fo]).Like redis-rb, it treats the first Array element as the
key, and the remaining elements as K, V pairs. The other tests the method performed before this change still work. If the Array provided does not contain an odd number of elements (size >= 3), the sameRedis::CommandErroris raised as before.